HDDS-1915. Remove hadoop script from ozone distribution#1233
Closed
elek wants to merge 1 commit intoapache:trunkfrom
Closed
HDDS-1915. Remove hadoop script from ozone distribution#1233elek wants to merge 1 commit intoapache:trunkfrom
elek wants to merge 1 commit intoapache:trunkfrom
Conversation
|
🎊 +1 overall
This message was automatically generated. |
bharatviswa504
approved these changes
Aug 6, 2019
Contributor
bharatviswa504
left a comment
bharatviswa504
left a comment
There was a problem hiding this comment.
+1 LGTM.
Ya with this, we can eliminate trunk version of hadoop and hadoop.cmd script.
Contributor
|
@arp7 can you also take a look at this change. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
|
@elek Thanks for the contribution. @bharatviswa504 Thanks for the review. I have committed this to the trunk. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/bin/hadoop script is included in the ozone distribution even if we a dedicated /bin/ozone
[~arp] reported that it can be confusing, for example "hadoop classpath" returns with a bad classpath (ozone classpath ) should be used instead.
To avoid such confusions I suggest to remove the hadoop script from distribution as ozone script already provides all the functionalities.
It also helps as to reduce the dependencies between hadoop 3.2-SNAPSHOT and ozone as we use the snapshot hadoop script as of now.
See: https://issues.apache.org/jira/browse/HDDS-1915